Win32 fixes #2
Open
Win32 fixes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, renaming or overwriting an open file will fail, so we make sure that we close all filehandles quickly because updatedir() wants to create/overwrite CHECKSUMS
This means the files will be identical whether run on Windows or Unixish OSes
... done under Windows but the newlines match a file generated under a unixish OS
|
Thanks for banging this out, I was a bit unsure on the correct fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches address the Win32 compatibility.
Mostly this is
\r\nvs\ndifferences in text files, which is handling by usingbinmode()resp.:rawon the filehandles when reading/writing text data. This means all files only use\nas newline.The other problem was Windows not liking open files getting renamed/overwritten. This was handled by closing
all files before they get renamed/overwritten.
https://rt.cpan.org/Public/Bug/Display.html?id=151008 can be closed.
#1 can be closed.
https://perlmonks.org/?node_id=11144340 can be updated with the resolution :)