RT #107353 says that we need to ignore SIGWINCH#160
Open
briandfoy wants to merge 1 commit intoandk:masterfrom
Open
RT #107353 says that we need to ignore SIGWINCH#160briandfoy wants to merge 1 commit intoandk:masterfrom
briandfoy wants to merge 1 commit intoandk:masterfrom
Conversation
The previous change only ignored WINCH if that key existed in the %SIG hash. The Changes log entry from 2.14-TRIAL noted that setting this for systems that do not support WINCH could be noisy. I'm guessing that's the old Mac OS X. If we don't mind old things complaining, we can always set it unless something got there first. Or, let's add some notes about what concrete problems come up when we always set it.
Author
|
What needs to happen for this PR to move forward? |
briandfoy
added a commit
to briandfoy/app-cpan-upgraded
that referenced
this pull request
Jan 11, 2025
These changes fix: andk/cpanpm#160, andk/cpanpm#168, andk/cpanpm#131, andk/cpanpm#169, andk/cpanpm#167, andk/cpanpm#170, andk/cpanpm#166, andk/cpanpm#171, andk/cpanpm#161, andk/cpanpm#165 These are also noted in my intention to fork in andk/cpanpm#167
briandfoy
added a commit
to briandfoy/app-cpan-upgraded
that referenced
this pull request
Jan 11, 2025
These changes fix: andk/cpanpm#160, andk/cpanpm#168, andk/cpanpm#131, andk/cpanpm#169, andk/cpanpm#167, andk/cpanpm#170, andk/cpanpm#166, andk/cpanpm#171, andk/cpanpm#161, andk/cpanpm#165 These are also noted in my intention to fork in andk/cpanpm#187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://rt.cpan.org/Ticket/Display.html?id=107353
The previous change only ignored WINCH if that key existed in the %SIG hash. The Changes log entry from 2.14-TRIAL noted that setting this for systems that do not support WINCH could be noisy. I'm guessing that's the old Mac OS X.
If we don't mind old things complaining, we can always set it unless something got there first.
Or, let's add some notes about what concrete problems come up when we always set it.