chore: upgrade Gradle, AGP, Kotlin and fix build errors for new contributors#428
Closed
Prathvi-Raj-Chauhan wants to merge 3 commits into
Closed
chore: upgrade Gradle, AGP, Kotlin and fix build errors for new contributors#428Prathvi-Raj-Chauhan wants to merge 3 commits into
Prathvi-Raj-Chauhan wants to merge 3 commits into
Conversation
…version of notifications package
…id sdk 36 or higher
❌ Deploy Preview for aquamarine-kheer-83feda failed. Why did it fail? →
|
|
Thank you for submitting your pull request! We'll review it as soon as possible. |
Author
|
@andoriyaprashant awesome_notifications is under dev_dependencies, shouldn't it be under dependencies since it's used at runtime ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
New contributors were unable to build the project due to outdated
Gradle, AGP, and Kotlin versions causing compilation errors.
Changes
Tested on