Fix Notification Flooding & Build Method Side-Effects#446
Open
sandy4242 wants to merge 2 commits into
Open
Conversation
❌ Deploy Preview for aquamarine-kheer-83feda failed. Why did it fail? →
|
|
Thank you for submitting your pull request! We'll review it as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Issue No.
Describe Problem / Root Cause
Solution proposed
lib/services/notificationService.dartto make notification IDs deterministic.lib/opso_timeline.dartto convertOpsoTimeLineScreento aStatefulWidgetand move the scheduling logic toinitState.Implement a helper method to generate deterministic positive 31-bit integer IDs from the notification's description and body. This prevents duplication when notifications are re-scheduled.
Update
_scheduleNotificationto use this deterministic ID instead of generating a new one via timestamp(DateTime.now().millisecondsSinceEpoch).Simplify the permission check logic in
_scheduleNotificationto eliminate redundant checks and duplicate code blocks.Convert
OpsoTimeLineScreenfrom aStatelessWidgetto aStatefulWidget.Move the loop that schedules notifications out of the build method and into a helper method called from
initState.Ensure that the build method is pure and only returns the widget tree without triggering any side-effects.
Additional Information