fix: handle project showcase images in dark mode#448
Closed
adityashirsatrao007 wants to merge 1 commit into
Closed
fix: handle project showcase images in dark mode#448adityashirsatrao007 wants to merge 1 commit into
adityashirsatrao007 wants to merge 1 commit into
Conversation
❌ Deploy Preview for aquamarine-kheer-83feda failed. Why did it fail? →
|
|
Thank you for submitting your pull request! We'll review it as soon as possible. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds dark mode support to the GSoC project widget by adapting the background color and applying a white backdrop behind project logos so transparent/dark logos remain visible on dark backgrounds.
Changes:
- Switches the logo container background between
grey[800]andgrey[100]based onisDarkMode. - Wraps the network image in a
ColorFilteredwithBlendMode.dstOverto place a translucent white layer behind logos in dark mode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Container( | ||
| padding: EdgeInsets.all(20), | ||
| color: Colors.grey[100], | ||
| color: isDarkMode ? Colors.grey[800]: Colors.grey[100], |
Comment on lines
+123
to
+127
| child: ColorFiltered( | ||
| colorFilter: ColorFilter.mode( | ||
| isDarkMode ? Colors.white.withOpacity(0.85) : Colors.transparent, | ||
| BlendMode.dstOver, | ||
| ), |
| height: 80, | ||
| child: ColorFiltered( | ||
| colorFilter: ColorFilter.mode( | ||
| isDarkMode ? Colors.white.withOpacity(0.85) : Colors.transparent, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes project showcase images that have white backgrounds looking out of place in dark mode.
Changes:
Closes #435