fix: remove debug print statements from BookMarkScreen#469
Closed
adityashirsatrao007 wants to merge 1 commit into
Closed
fix: remove debug print statements from BookMarkScreen#469adityashirsatrao007 wants to merge 1 commit into
adityashirsatrao007 wants to merge 1 commit into
Conversation
Remove 3 production print() statements from BookMarkScreen widget:
- print("working") - debug log on every FutureBuilder rebuild
- print(snapshot.data) - logs bookmark data on every rebuild
- print(bookmarks) - logs Future object when list is empty
These debug logs run on every widget rebuild, degrading performance
and violating the avoid_print lint rule. Fixes #417.
❌ Deploy Preview for aquamarine-kheer-83feda failed. Why did it fail? →
|
|
Thank you for submitting your pull request! We'll review it as soon as possible. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes debug print statements from the bookmark screen's FutureBuilder.
Changes:
- Removed two
printcalls used for debugging inBookMarkScreen.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes 3 debug
print()statements from theBookMarkScreenwidget's FutureBuilder.Problem
In
lib/widgets/book_mark_screen.dart, the FutureBuilder's builder callback contained:These run on every widget rebuild, causing:
avoid_printlint rule from BUG: Improved linting and code quality #417Fix
Removed all 3
print()statements. The logic is unchanged.Related Issue
Fixes #417 (Improved linting and code quality)
Type of Change
Checklist