fix: replace print() with debugPrint() in SWOCScreen and LinuxFoundation#471
Closed
adityashirsatrao007 wants to merge 1 commit into
Closed
Conversation
…creens
social_winter_of_code.dart (_loadProjects):
- Remove print() on successful project load (noisy, runs for every JSON file)
- Replace print() on empty JSON with debugPrint() (keep as warning, strip in release)
- Replace print() on load error with debugPrint() (keep for error tracing)
linux_foundation.dart:
- Remove print('Adding') before HandleBookmark.addBookmark()
- Remove print('Deleting') before HandleBookmark.deleteBookmark()
- Remove print('value is $value') in search onFieldSubmitted callback
All debug-only logs are either removed or replaced with debugPrint() which
is automatically stripped in release builds. Fixes #417.
❌ Deploy Preview for aquamarine-kheer-83feda failed. Why did it fail? →
|
|
Thank you for submitting your pull request! We'll review it as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes or replaces debug
print()statements in two program screens.Problem
Both screens used bare
print()statements that run in production:social_winter_of_code.dart—_loadProjects()method:linux_foundation.dart— bookmark toggle & search callbacks:Fix
debugPrint()(stripped in release builds automatically by Flutter)Related Issue
Fixes #417 (Improved linting and code quality)
Type of Change
Checklist
debugPrint()is Flutter's recommended replacement forprint()in widget code