fix: remove debug print() statements from MLH, SoB, GSoC, and GSoD screens#472
Closed
adityashirsatrao007 wants to merge 1 commit into
Closed
Conversation
…reens
major_league_hacking_fellowship.dart:
- Remove print('Adding') and print('Deleting') in bookmark toggle handler
summer_of_bitcoin.dart:
- Remove print('Adding') and print('Deleting') in bookmark toggle handler
google_summer_of_code_screen.dart:
- Remove dead empty kDebugMode blocks in bookmark toggle handler
- Remove print(selectedLanguages) inside kDebugMode block in language filter
- Remove unused 'package:flutter/foundation.dart' import
google_season_of_docs_screen.dart:
- Remove print('!@# $selectedOrganizations') in filterProjects()
- Remove print('this is selected organization ...') in onConfirm callback
Fixes #417 (Improved linting and code quality)
❌ Deploy Preview for aquamarine-kheer-83feda failed. Why did it fail? →
|
|
Thank you for submitting your pull request! We'll review it as soon as possible. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes noisy debug logging from multiple program screens and cleans up related imports.
Changes:
- Removed
print(...)statements around bookmark actions and filtering. - Dropped
flutter/foundation.dartimport wherekDebugModeis no longer used. - Reduced console output during filter selection updates.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/programs screen/summer_of_bitcoin.dart | Removes bookmark add/delete debug prints. |
| lib/programs screen/major_league_hacking_fellowship.dart | Removes bookmark add/delete debug prints. |
| lib/programs screen/google_summer_of_code_screen.dart | Removes kDebugMode/prints and the now-unneeded foundation import. |
| lib/programs screen/google_season_of_docs_screen.dart | Removes debug prints inside filtering and selection updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (isBookmarked) { | ||
| print("Adding"); | ||
|
|
||
| HandleBookmark.addBookmark(currentProject, currectPage); |
| if (isBookmarked) { | ||
| print("Adding"); | ||
|
|
||
| HandleBookmark.addBookmark(currentProject, currectPage); |
Comment on lines
+76
to
+79
|
|
||
| HandleBookmark.addBookmark(currentProject, currectPage); | ||
| } else { | ||
| print("Deleting"); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes debug
print()statements from 4 program screens that were left in production code.Files Changed
major_league_hacking_fellowship.dartprint("Adding")andprint("Deleting")in bookmark toggle handlersummer_of_bitcoin.dartprint("Adding")andprint("Deleting")in bookmark toggle handlergoogle_summer_of_code_screen.dartkDebugModeblocks in bookmark toggle (leftover from a partial refactor)print(selectedLanguages)insidekDebugModeblock in language filter callbackimport 'package:flutter/foundation.dart'google_season_of_docs_screen.dartprint("!@# $selectedOrganizations")infilterProjects()(runs on every filter change)print("this is selected organization...")in org filteronConfirmcallbackRelated Issue
Fixes #417 (Improved linting and code quality)
Type of Change
Checklist