Add install smoke tests for release artifacts and Homebrew#35
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an automated “install smoke test” layer to validate that built release artifacts start successfully and that core, non-mutating CLI commands work in a clean environment (isolated HOME). This strengthens release/CI confidence by catching packaging/install regressions earlier.
Changes:
- Introduces
scripts/smoke-test-release.shto run--help,--version,doctor,metadata, andfeature listunder an isolatedHOME, plus optional Homebrew verification. - Adds
make smoke-testand wires smoke tests into CI and the release workflow prior to publishing artifacts. - Documents verification steps in
README.mdand records the change inCHANGELOG.md.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/smoke-test-release.sh | New smoke test script for validating binaries in an isolated HOME with optional Homebrew checks. |
| README.md | Adds install verification instructions (including Homebrew verification toggle). |
| Makefile | Adds smoke-test target and help output entry. |
| CHANGELOG.md | Notes the new smoke test tooling and workflow integration. |
| .github/workflows/release.yml | Runs smoke tests before invoking GoReleaser. |
| .github/workflows/ci.yml | Runs smoke tests for built binaries in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+6
| binary="${1:-bin/mcp-wire}" | ||
| homebrew_verify="${SMOKE_TEST_HOMEBREW:-false}" | ||
|
|
| exit 1 | ||
| fi | ||
|
|
||
| isolated_home=$(mktemp -d) |
| To also verify a Homebrew-installed copy when `mcp-wire` is present in your Cellar: | ||
|
|
||
| ```bash | ||
| SMOKE_TEST_HOMEBREW=true ./scripts/smoke-test-release.sh |
- Add scripts/smoke-test-release.sh to verify built binaries run --help, --version, doctor, metadata, and feature list in an isolated HOME without touching user MCP config. - Add make smoke-test target that builds and smoke-tests bin/mcp-wire. - Run smoke tests in CI and release workflows before GoReleaser. - Document verification steps in README.md, including optional Homebrew-installed copy checks. Closes #11
andreagrandi
force-pushed
the
smoke-tests-release-artifacts
branch
from
c3d60fb to
26383c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds automated smoke tests for release artifacts and optional Homebrew verification.
Changes:
scripts/smoke-test-release.shverifies a built binary runs--help,--version,doctor,metadata, andfeature listin an isolated temporaryHOME, ensuring no user MCP config or credentials are touched.make smoke-testtarget builds and runs the smoke tests.SMOKE_TEST_HOMEBREW=true.Closes #11