Skip to content

Removed recursive subview hiding. #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed recursive subview hiding. #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions Source/ScrollingNavigationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,35 +617,6 @@ open class ScrollingNavigationController: UINavigationController, UIGestureRecog
}
}

// Hide all possible button items and navigation items
func shouldHideView(_ view: UIView) -> Bool {
let className = view.classForCoder.description().replacingOccurrences(of: "_", with: "")
var viewNames = ["UINavigationButton", "UINavigationItemView", "UIImageView", "UISegmentedControl"]
if #available(iOS 11.0, *) {
viewNames.append(navigationBar.prefersLargeTitles ? "UINavigationBarLargeTitleView" : "UINavigationBarContentView")
} else {
viewNames.append("UINavigationBarContentView")
}
return viewNames.contains(className)
}

func setAlphaOfSubviews(view: UIView, alpha: CGFloat) {
if let label = view as? UILabel {
label.textColor = label.textColor.withAlphaComponent(alpha)
} else if let label = view as? UITextField {
label.textColor = label.textColor?.withAlphaComponent(alpha)
} else if view.classForCoder == NSClassFromString("_UINavigationBarContentView") {
// do nothing
} else {
view.alpha = alpha
}
view.subviews.forEach { setAlphaOfSubviews(view: $0, alpha: alpha) }
}

navigationBar.subviews
.filter(shouldHideView)
.forEach { setAlphaOfSubviews(view: $0, alpha: alpha) }

// Hide the left items
navigationItem.leftBarButtonItem?.customView?.alpha = alpha
navigationItem.leftBarButtonItems?.forEach { $0.customView?.alpha = alpha }
Expand Down