add sitemapindex generator #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the generate_sitemapindex function which takes a list of dicts containing a 'loc' key and optionall a lastmod key (containing a datetime.date or datetime.datetime object) and creates a sitemapindex file.
This patch replaces the __init__ of FixedOffset with a set method instead. This is so we can unpickle datetime objects using this tzinfo based class as a tzinfo= argument. you can read all about it at https://docs.python.org/2/library/datetime.html#tzinfo-objects I ran into this while trying to unpickle a pickled dictionary filled with UrlSetElement objects that I had read in from the sitemap library which had a lastmod set in the parsed sitemap you get a nasty traceback complaining about __init__ requiring 4 arguments but only one given with out much useful info on what inside the pickle file caused it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the generate_sitemapindex function which takes a list of dicts containing
a 'loc' key and optionall a lastmod key (containing a datetime.date or
datetime.datetime object) and creates a sitemapindex file.