Feb 2025 API updates - restore min viable#5
Closed
jbruns wants to merge 1 commit intoandrewdefilippis:mainfrom
jbruns:main
Closed
Feb 2025 API updates - restore min viable#5jbruns wants to merge 1 commit intoandrewdefilippis:mainfrom jbruns:main
jbruns wants to merge 1 commit intoandrewdefilippis:mainfrom
jbruns:main
Conversation
Owner
|
Thank you for letting me know the API had changed, and for submitting your PR. Looks like some tests are failing with this set of changes. I'm going to pull this in, and work on releasing a new version as soon as I can get it done. |
Owner
|
Closing to update in #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the myschoolmenus API might have changed this month. These changes restore the ability to generate ICS files and thus make the example code work again. You obviously have much more built into the API which I have not found exact equivalents for, yet.