A few changes I had to make to get it running #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry for the inattention to this PR! I merged some other stuff, so I've you're still interested, please rebase and fix the merge conflicts. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When I tried to run buildPlayerDictionary, I wasn't getting player height, weight or position. The tag you've been using isn't in the Basketball Reference css anymore so I updated that. I also found that the game logs weren't being parsed correctly, it was trying to add the splits with the game logs, so I set it to only save the logs. The post-season logs were being hidden in a comment, so I wrote a little code to parse them and pull out the relevant table.
-Todd