Update CSV reader logic to work with Python 3 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the type of the `csv_obj.csv` field will be a `bytes`, we need to decode that into a utf-8 `str` before passing it into `csv.reader()`. This avoids the headers being parsed incorrectly, such as the first field being named `b'My Field`.
|
So while our branch might be too opinionated (I started with a pre-commit run on all-the-things), posting this here in case someone else finds it to be helpful https://github.com/djangocon/grorg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think Heroku forcibly upgraded grorg to Python 3, which broke CSV loading.
Because the type of the
csv_obj.csvfield will be abytes, we need to decode that into a utf-8strbefore passing it intocsv.reader(). This avoids the headers being parsed incorrectly, such as the first field being namedb'My Field.This also fixes migrations to work with Python 3 and replaces
__unicode__with__str__CSV parsing works now!
