Add InsecureHttp and InsecureWs options#273
Merged
andrewlock merged 1 commit intomainfrom Nov 8, 2025
Merged
Conversation
…g not using this API
Test Results 39 files ± 0 39 suites ±0 28m 5s ⏱️ + 9m 3s Results for commit 0e31fe0. ± Comparison against base commit 6151e94. This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tiesont flagged that we need
http:andws:for browserlink, so added the insecure options too:OverInsecureHttp()OverInsecureWs()To try to discourage their use in general (because they allow insecure usage), added an analyzer to mark them as insecure. That said, it seemed weird to make them Warnings, so just added them as Info, the same as in #272. If you want to be safe, you can always increase the level:
Also, small fix, moved the
data:andblob:to the scheme source attribute