fix: prevent shared state between client instances#259
Open
calicube wants to merge 1 commit intoandrewyng:mainfrom
Open
fix: prevent shared state between client instances#259calicube wants to merge 1 commit intoandrewyng:mainfrom
calicube wants to merge 1 commit intoandrewyng:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
provider_configsfield in theClientclass was using a mutable default argument (dict = {}). This caused shared state issues where modifying the configuration of oneClientinstance would inadvertently affect all other instances initialized with the default value.Changes:
provider_configsdefault value from{}toNoneinClient.__init__.self.provider_configsas a new dictionary ifNoneis provided.Root Cause
Default arguments are evaluated only once at function definition time. Using a mutable object like a dictionary as a default argument leads to a persistent object shared across all calls that do not provide an explicit value.
Solution