Skip to content

[deploy] get image from ghcr #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[deploy] get image from ghcr #119

wants to merge 1 commit into from

Conversation

capcom6
Copy link
Member

@capcom6 capcom6 commented Feb 15, 2025

Summary by CodeRabbit

  • Chores
    • The Docker deployment now sources its container image from a new GitHub Container Registry, ensuring updated infrastructure while maintaining existing settings.

Copy link

coderabbitai bot commented Feb 15, 2025

Walkthrough

This pull request updates the Terraform configuration for a Docker service by changing the image reference in the docker_image resource of the deployments/docker-swarm-terraform/main.tf file. The image name is updated from using a custom repository format (capcom6/${var.app-name}:${var.app-version}) to a GitHub Container Registry format (ghcr.io/android-sms-gateway/server:${var.app-version}). No other modifications were made; all additional configurations for networks, secrets, and service settings remain unchanged.

Changes

File Change Summary
deployments/docker-swarm-terraform/main.tf Updated the docker_image resource image name from capcom6/${var.app-name}:${var.app-version} to ghcr.io/android-sms-gateway/server:${var.app-version}

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c9d6ad and b47fffc.

📒 Files selected for processing (1)
  • deployments/docker-swarm-terraform/main.tf (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: E2E
  • GitHub Check: Test
  • GitHub Check: lint
  • GitHub Check: Analyze (go)
🔇 Additional comments (1)
deployments/docker-swarm-terraform/main.tf (1)

10-10: Update Docker Image Reference

The image name at line 10 has been updated to "ghcr.io/android-sms-gateway/server:${var.app-version}", replacing the previous repository format. Please verify that this fixed repository reference is intentional, that it aligns with your deployment strategy, and that the deployment environment has the proper credentials (if needed) to pull from GitHub Container Registry. This change also removes the dynamic ${var.app-name} component from the image name, so ensure that this is desired.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@capcom6 capcom6 closed this Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant