Add triggers to .github/workflows/ #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note The files in this pull request are not supported by Gemini Code Assist. |
Contributor
Author
|
CI is not working on this repository, likely due to this issue: The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002 I will try to update the environment to |
Fixes this error: The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002
Responding to error: "This is a scheduled Ubuntu 20.04 retirement. Ubuntu 20.04 LTS runner will be removed on 2025-04-15. For more details, see actions/runner-images#11101""
Contributor
Author
|
|
The builds are failing: * Error: Missing download info for actions/upload-artifact@v1
ray-google
approved these changes
Jun 4, 2025
Verified by running:
.github/scripts/gradlew_recursive.sh assembleDebug
This commit updates the build workflow to set up JDK 11 in addition to JDK 17. This ensures that the project can be built with both JDK versions.
This commit reverts the JDK version used for the Camera2Basic project to 1.8. This change addresses compatibility issues encountered with the newer JDK 17. The following changes were made: - Modified `Camera2Basic/build.gradle` to use `VERSION_1_8`. - Removed `org.gradle.java.home` from `Camera2Basic/gradle.properties`. - Removed `org.gradle.java.home` from `CameraXExtensions/gradle.properties`. - Added `.java-version` files to specify java versions.
This commit adds `.java-version` files to specify the java versions to be used for different modules within the project. This ensures that the correct JDK is used for each module, avoiding compatibility issues. The following changes were made: - Added `.java-version` 17 file to root directory. - Added `.java-version` 11 file to `Camera2SlowMotion` directory. - Added `.java-version` 11 file to `CameraUtils` directory. - Added `.java-version` 11 file to `HdrViewfinder` directory.
The HdrViewfinder sample was failing to build due to outdated Gradle and Android Gradle Plugin versions. This commit updates the sample to use more modern tools and libraries, and fixes the resulting build errors. Changes: - Updated Gradle to 7.5.1 - Updated Android Gradle Plugin to 7.2.0 - Updated compileSdkVersion and targetSdkVersion to 33 - Enabled AndroidX and migrated dependencies - Updated Java imports to use AndroidX - Fixed manifest to explicitly set `android:exported`
This commit refactors the `android.yml` workflow file to create separate workflows for each module in the project. This change improves build parallelism and reduces the overall build time. The following changes were made: - Deleted the `gradlew_recursive.sh` script. - Modified `android.yml` to define individual jobs for each module (CameraXBasic, CameraXExtensions, CameraXVideo, CameraXAdvanced, CameraX-MLKit, Camera2Basic, Camera2Extensions, Camera2Video, Camera2SlowMotion, CameraUtils, HdrViewfinder). - Each job checks out the code, sets up the appropriate JDK, builds the project, zips the artifacts, and uploads the artifacts.
This commit updates the `android.yml` workflow file to specify the `working-directory` for each job's build and zip steps. This change ensures that the commands are executed in the correct directory. The following changes were made: - Added `working-directory` to the `Build project` step. - Added `working-directory` to the `Zip artifacts` step.
This commit updates the names of the uploaded artifacts in the `android.yml` workflow file to avoid artifact naming conflicts. The following changes were made: - Renamed artifact name from `assemble` to `camerax_basic_assemble` for CameraXBasic module. - Renamed artifact name from `assemble` to `camerax_extensions_assemble` for CameraXExtensions module. - Renamed artifact name from `assemble` to `camerax_video_assemble` for CameraXVideo module. - Renamed artifact name from `assemble` to `camerax_advanced_assemble` for CameraXAdvanced module. - Renamed artifact name from `assemble` to `camerax_mlkit_assemble` for CameraX-MLKit module. - Renamed artifact name from `assemble` to `camera2_basic_assemble` for Camera2Basic module. - Renamed artifact name from `assemble` to `camera2_extensions_assemble` for Camera2Extensions module. - Renamed artifact name from `assemble` to `camera2_video_assemble` for Camera2Video module. - Renamed artifact name from `assemble` to `camera2_slowmotion_assemble` for Camera2SlowMotion module. - Renamed artifact name from `assemble` to `camerautils_assemble` for CameraUtils module. - Renamed artifact name from `assemble` to `hdrviewfinder_assemble` for HdrViewfinder module.
This commit updates the Gradle Wrapper in the HdrViewfinder sample to a more recent version. This resolves compatibility issues and ensures that the project can be built with modern tools. Changes: - Updated gradle-wrapper.jar - Updated gradle-wrapper.properties to use Gradle 7.3.3 - Updated gradlew and gradlew.bat scripts
Contributor
Author
|
@madebymozart let me know how you want to support HdrViewfinder. I might remove it from the list of projects to run in this PR to unblock the others, but we should have a plan to either fix or deprecate HdrViewfinder. |
This commit removes the HdrViewfinder job from the `android.yml` workflow file. The following changes were made: - Removed the `HdrViewfinder` job from `android.yml`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardizes GitHub Actions triggers in workflow files within
.github/workflows/.The goal is to ensure workflows run consistently on
push,pull_request, andworkflow_dispatchevents where appropriate.This is part of a batch of pull requests across repositories owned by the
androidorganization on GitHub.Project Owner: Please review the changes carefully to ensure they are correct and appropriate for this project before approving and merging.