Skip to content

Baseline Profile Codelab Sample App - Replaces unsplash urls with static images #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025

Conversation

AjeshRPai
Copy link
Contributor

Description

This PR replaces unsplash image urls used in snacks with static images and updates the screen ui to respect edge to edge displays

Test instructions:

Static images

  1. Run the app from the main branch
  2. Notice that the images for snacks are not shown
  3. Run the app from this branch
  4. Verify that the images for snacks are shown

Edge to Edge display

  1. Run the app from this branch
  2. Notice that the ui respect edge to edge displays

Replaces: unsplash image urls with static images
Updates: composable to respect edge to edge displays
@AjeshRPai AjeshRPai requested a review from mlykotom June 6, 2025 07:57
@AjeshRPai AjeshRPai requested a review from a team as a code owner June 6, 2025 07:57
Copy link
Collaborator

@mlykotom mlykotom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove the comments, othwerise LGTM.

Also, make sure to cherry-pick the changes to the end branch as well

@AjeshRPai AjeshRPai merged commit 598c8a4 into main Jun 6, 2025
2 checks passed
@AjeshRPai AjeshRPai deleted the bugfix/static-images branch June 6, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants