-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Jetcaster Material Expressive update #1565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 31 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
6681eee
Add to Jetcaster: shared elements, swipetodismiss, lazy list animatio…
simona-anomis 87b8385
Spotless formatting
simona-anomis 15a032e
Remove comments and add mapping logic
simona-anomis 3158d1d
Merge branch 'main' into anomis/jetcaster-ui-update
simona-anomis 260cb85
Merge branch 'main' into anomis/jetcaster-ui-update
simona-anomis a27c1ca
Add shared elements, swipe to dismiss and removal logic to Jetcaster
simona-anomis 3aebb7a
Add fade in and fade out for the player thumbnail placeholder
simona-anomis b90e21a
spotless formatting
simona-anomis 91aa707
test spotless
simona-anomis b8e47f3
Merge main and resolve conflicts by adding removeEpisode to HomeActions
simona-anomis c7d597d
Adding dependencies and updating Theme file
MagicalMeghan ad737d4
Updating theme colors
MagicalMeghan dc3be91
Rounding the filter buttons
MagicalMeghan 7513f23
Remove hero carousel from Discover
MagicalMeghan 47e188d
Merge "Rounding the filter buttons" into main
MagicalMeghan faa0737
Merge "Updating theme colors" into main
riggaroo bdfaf28
Adding horizontal carousel
MagicalMeghan d32ecce
Adding pill toolbar
MagicalMeghan f247113
Merged main
MagicalMeghan c97e7de
adding uncontained carousel to discover tab
MagicalMeghan d80640e
Adding Media Player for podcast using "media3 ui compose"
satishshendeg 4bf631f
updating typography for player screen
MagicalMeghan 385ccd0
Merge "updating typography for player screen" into main
MagicalMeghan 4f2e5cd
Update Podcast Detail Screen Layout
MagicalMeghan d49f3e3
update player buttons on player screen
MagicalMeghan 7ea3c88
Updating discover carousel buttons
MagicalMeghan df55641
Merge "Update Podcast Detail Screen Layout" into main
MagicalMeghan 02db77d
Merge "update player buttons on player screen" into main
MagicalMeghan 6ff9397
Resolve merge conflicts
MagicalMeghan a1fd2b0
update media 3
MagicalMeghan 96a29e2
Spotless fixes
MagicalMeghan d0581e2
Fix spotless for Jetcaster
mlykotom bb567f5
Apply spotless for Jetcaster
mlykotom c11adad
Fixes spotless checks for Jetcaster (#1566)
mlykotom 3ab21f6
Fix unstable api lint
mlykotom 56422b5
Update Episode params
MagicalMeghan 8f39bce
spotless
MagicalMeghan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
ListOfStringConverteruses a simple comma (,) as a delimiter for storing a list of media URLs as a single string. While this works for many cases, could there be a scenario where a URL itself might contain a comma? If so, this would lead to incorrect parsing.Consider if a more robust serialization method, like storing the list as a JSON array string (e.g., using
kotlinx.serialization), might be safer for future-proofing, or if it's confirmed that media URLs will never contain commas.