Try to access query parameters only if its hierarchical URI

[varshagodage]

Non hierarchical URI(any URI without // after scheme name) results in crash now with following error:
Exception java.lang.UnsupportedOperationException: This isn't a hierarchical URI.
at android.net.Uri.getQueryParameterNames (Uri.java:1605)

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical crash that occurred when the application attempted to process non-hierarchical URIs. By introducing a conditional check, the system now safely handles URIs without a hierarchical structure, preventing an UnsupportedOperationException and improving the robustness of deep link parsing.

Highlights

• Crash Fix for Non-Hierarchical URIs: Implemented a check to ensure uri.isHierarchical is true before attempting to access query parameters, preventing an UnsupportedOperationException when processing non-hierarchical URIs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• app/src/main/java/com/example/nav3recipes/deeplink/basic/util/DeepLinkRequest.kt
  • Added a conditional check for uri.isHierarchical before accessing query parameters.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request effectively addresses the UnsupportedOperationException by conditionally accessing query parameters only when the URI is hierarchical. This is a crucial fix for handling non-hierarchical URIs gracefully and prevents application crashes. The change is well-implemented and directly resolves the reported issue.

[claraf3]

Thanks for the PR.

This would just silently ignore non-hierarchical URIs which i'm not sure is better than a crash that alerts people.

Ideally it would handle non-hierachical URIs as well but i'm not sure what the best way to do that is. Would you like to give this a crack?