Resolve asprintf undeclared error and add cross-platform support #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include unistd.h only for non-Windows systems
- Define PAGESIZE as 4096 on Windows, sysconf(_SC_PAGESIZE) elsewhere
- Update aligned_offset calculation to use PAGESIZE macro
Fixes the error -
output_file.cpp:660:39: error: '_SC_PAGESIZE' was not declared in this scope
660 | aligned_offset = offset & ~(sysconf(_SC_PAGESIZE) - 1);
| ^~~~~~~~~~~~
output_file.cpp:660:31: error: 'sysconf' was not declared in this scope; did you mean 'swscanf'?
…nd append2simg - Resolve 'asprintf was not declared in this scope' error in append2simg.cpp:67:9 by replacing asprintf with custom_asprintf using snprintf - Add custom_asprintf implementation to address missing asprintf declaration - Reorder calloc args to (count, size) in simg2simg.cpp, sparse.cpp, and append2simg.cpp
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two changes:
Cross-platform support in output_file.cpp and backed_block.cpp
#ifndef _WIN32around<unistd.h>and definedPAGESIZE(4096 for Windows,sysconf(_SC_PAGESIZE)elsewhere) inoutput_file.cppfor non-POSIX compatibility.aligned_offsetlogic to use thePAGESIZEmacro for consistent alignment.callocargs inbacked_block.cppfromsizeof(struct backed_block_list), 1to1, sizeof(struct backed_block_list)for clarity.Portability fixes in simg2simg.cpp, sparse.cpp, and append2simg.cpp
callocargs (e.g.,sizeof(struct sparse_file*), filestofiles, sizeof(struct sparse_file*)) across all three files.asprintfwith a customcustom_asprintfusingsnprintfinappend2simg.cppto resolve "append2simg.cpp:67:9: error: 'asprintf' was not declared in this scope". Thecustom_asprintfimplementation fixes this compilation failure.Fixes issue #44 with these commits.
Testing:
ubuntu-latestandwindows-latest. Builds pass without issues.Closes Issue #44.