Add cmake options for building engine simulator as a library#338
Open
nicholas477 wants to merge 3 commits intoange-yaghi:masterfrom
Open
Add cmake options for building engine simulator as a library#338nicholas477 wants to merge 3 commits intoange-yaghi:masterfrom
nicholas477 wants to merge 3 commits intoange-yaghi:masterfrom
Conversation
carne8
approved these changes
Dec 30, 2022
Miou-zora
reviewed
Jun 25, 2024
Co-authored-by: Miouzora <91665686+Miou-zora@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits up the executable into a static lib (engine-sim-app-lib) and fixes unused dependencies being added and compiled.
It also adds two more options to CMake: BUILD_APP and BUILD_APP_LIB.