Skip to content

fix: what the fuck #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stathis-alexander merged 8 commits into from
Jun 19, 2025
Merged

fix: what the fuck #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
27c8ceb
fix: what the fuck
stathis-alexander Jun 19, 2025
a16f3af
stathis-alexander Jun 19, 2025
14fea89
stathis-alexander Jun 19, 2025
e0bb072
stathis-alexander Jun 19, 2025
5a336c6
stathis-alexander Jun 19, 2025
68ae2a5
stathis-alexander Jun 19, 2025
72798d9
stathis-alexander Jun 19, 2025
1d5b11c
stathis-alexander Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/download
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ source "${plugin_dir}/lib/utils.bash"
mkdir -p "$ASDF_DOWNLOAD_PATH"

# Download tar.gz file to the download directory
download_release "$ASDF_INSTALL_VERSION" $(release_file $ASDF_DOWNLOAD_PATH)
download_release "$ASDF_INSTALL_VERSION" "$(release_file $ASDF_DOWNLOAD_PATH)"
2 changes: 1 addition & 1 deletion bin/latest-stable
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ printf "redirect url: %s\n" "$redirect_url" >&2
if [[ "$redirect_url" == "$GH_REPO/releases" ]]; then
version="$(list_all_versions | sort_versions | tail -n1 | xargs echo)"
else
version="$(printf "%s\n" "$redirect_url" | sed 's|.*/tag/v\{0,1\}||' | sed -E $REPLACE_RELEASE_REGEX)"
version="$(printf "%s\n" "$redirect_url" | sed 's|.*/tag/v\{0,1\}||' | sed -E "$REPLACE_RELEASE_REGEX")"
fi

printf "%s\n" "$version"
28 changes: 17 additions & 11 deletions lib/utils.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,10 @@ escape_slashes() {
MAJOR_1_PREFIX='cli/v'
MAJOR_2_PREFIX='@biomejs/biome@'

# match either @biomejs/biome@ or cli/v
RELEASE_PREFIX_REGEX='\(@biomejs/biome@\|cli\/v\)'

# match either @biomejs/biome@X.Y.Z or cli/vX.Y.Z
RELEASE_REGEX="^\($MAJOR_1_PREFIX\|$MAJOR_2_PREFIX\)[0-9]\+\.[0-9]\+\.[0-9]\+$"
REPLACE_RELEASE_REGEX="s/^($(escape_slashes $MAJOR_1_PREFIX)|$(escape_slashes $MAJOR_2_PREFIX))//"

echo $MAJOR_1_PREFIX | sed 's/\//\\\//'

fail() {
echo -e "asdf-$TOOL_NAME: $*"
exit 1
Expand All @@ -42,13 +37,11 @@ sort_versions() {
LC_ALL=C sort -t. -k 1,1 -k 2,2n -k 3,3n -k 4,4n -k 5,5n | awk '{print $2}'
}


# @biomejs/biome@[0-9]\+\.[0-9]\+\.[0-9]\+$
list_github_tags() {
git ls-remote --tags --refs "$GH_REPO" |
grep -o 'refs/tags/.*' | cut -d/ -f3- |
grep -o $RELEASE_REGEX | # Match semantic versioning tags
sed -E $REPLACE_RELEASE_REGEX
grep -o "$RELEASE_REGEX" | # Match semantic versioning tags
sed -E "$REPLACE_RELEASE_REGEX"
}

list_all_versions() {
Expand Down Expand Up @@ -76,11 +69,20 @@ release_file() {
}

download_release() {
local version filename url
local version filename url major_prefix
version="$1"
filename="$2"

url="$GH_REPO/releases/download/cli/v${version}/biome$(binary_suffix)"
if [[ $version =~ ^2 ]]; then
major_prefix="$MAJOR_2_PREFIX"
elif [[ $version =~ ^1 ]]; then
major_prefix="$MAJOR_1_PREFIX"
else
fail "Unsupported version: $version"
return 1
fi

url="$GH_REPO/releases/download/${major_prefix}${version}/biome$(binary_suffix)"

echo "* Downloading $TOOL_NAME release $version..."
curl "${curl_opts[@]}" -o "$filename" -C - "$url" || fail "Could not download $url"
Expand All @@ -91,6 +93,10 @@ install_version() {
local version="$2"
local install_path="${3%/bin}/bin"

if [ "$install_type" != "version" ]; then
fail "asdf-$TOOL_NAME supports release installs only"
fi

(
mkdir -p "$install_path"
mv $(release_file $ASDF_DOWNLOAD_PATH) "$install_path/$TOOL_NAME"
Expand Down