Ensure _temp dir does not interfere with pixel SOM and consensus cluster assignment#1183
Open
alex-l-kong wants to merge 4 commits intomainfrom
Open
Ensure _temp dir does not interfere with pixel SOM and consensus cluster assignment#1183alex-l-kong wants to merge 4 commits intomainfrom
_temp dir does not interfere with pixel SOM and consensus cluster assignment#1183alex-l-kong wants to merge 4 commits intomainfrom
Conversation
camisowers
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
If a run is restarted from the beginning, or if a
_tempdir still exists due to a crash, this creates a strange limbo state where the pipeline:_tempfolder if anoverwriteis forced (which is often the recommended solution in case the run is completely unsalvageable)How did you implement your changes
To address these issues:
_tempdirectory is seen onoverwrite=True, delete it firstpixel_pysomobject contains no SOM references insom_clusters_seen, invokes a new function,pixel_cluster_utils.identify_seen_pixel_clusters, to populate this. The function does extend support to meta clusters as well, though this case is not directly invoked in the pipeline.