Drop capstone <6.0 compat fallbacks and require capstone >=6.0 - #354
Open
kripticni wants to merge 3 commits into
Open
Drop capstone <6.0 compat fallbacks and require capstone >=6.0#354kripticni wants to merge 3 commits into
kripticni wants to merge 3 commits into
Conversation
- arch_aarch64.py: remove hasattr(CS_ARCH_AARCH64) fallback, use CS_ARCH_AARCH64 directly - arch_s390x.py: remove hasattr(CS_ARCH_SYSTEMZ) fallback, use CS_ARCH_SYSTEMZ directly - arch_riscv64.py: remove hasattr(CS_ARCH_RISCV) guard - pyproject.toml: add optional capstone>=6.0.0a1 dependency Uses >=6.0.0a1 because capstone has not shipped a stable 6.0.0 on PyPI yet (latest is 6.0.0a9). PEP 440 correctly orders 6.0.0a9 < 6.0.0, so >=6.0.0 would exclude all released versions. Per maintainer @twizmwazin's instruction on PR angr#353: "If bumping capstone to 6.0, please do remove the compat code for capstone<6. It should remain an optional dependency."
for more information, see https://pre-commit.ci
Contributor
Author
|
The ci job failures are expected. The angr/ci:3 container has capstone 5.x and the build installs angr@master which pins capstone==5.0.6. This PR needs the corresponding angr capstone bump at the same time. The test job (archinfo pytest) passes fine as-is. |
Member
|
Oh, I did not realize 6.0 was not stable yet! Let's keep the compat code around so that the latest stable version is still supported. But don't close this PR, we can merge it once 6.0 is released as stable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop capstone <6.0 compat fallbacks and require capstone >=6.0
Per maintainer @twizmwazin's instruction on PR #353:
"If bumping capstone to 6.0, please do remove the compat code for
capstone<6. It should remain an optional dependency."
Changes:
Note: uses >=6.0.0a1 because capstone has not shipped a stable 6.0.0
on PyPI yet (latest is 6.0.0a9). PEP 440 correctly orders pre-releases
before the release, so >=6.0.0 would exclude all published versions.