s390x: handle POPCNT total-count mode - #86
Open
DORA-B wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s390x
POPCNT(0xB9E1) is an RRF-c instruction. VEX currently decodes it as RRE, discarding the M3 field, and always returns per-byte population counts. This makes the M3=8 total-count form return an incorrect result.For example, with source
0xffffffffffffffff:b9e100cc(M3=0):0x0808080808080808b9e180cc(M3=8): should return64, but currently also returns0x0808080808080808IBM z/Architecture Principles of Operation SA22-7832-14, page 7-424 defines M3 bit 0 (encoded as numeric M3=8) as counting all set bits into a scalar result.
Fix
POPCNTwith the existing RRF-c-compatible formatter and extract M3.(m3 & 8)is set.Reproduction