arm: check SMLAD overflow on final result - #87
Open
DORA-B wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ARM
SMLADandSMLADXset the sticky Q flag when the complete signed sum of both halfword products andRadoes not fit in 32 bits. The current lifter checks overflow once after adding the products and again after addingRa. This incorrectly sets Q whenRacancels an intermediate overflow.Reproducer
With angr/pyvex 9.3.0:
Current output:
Expected output:
Each signed halfword product is
0x40000000. Their intermediate sum is0x80000000, but addingRa = -1produces the representable final result0x7fffffff. ARM defines the overflow test over this complete three-term result.Fix
Compute the complete signed sum in I64 and compare it with the sign extension of its low 32-bit result. Q is ORed only with that final representability check. The SMLSD/SMLSDX path retains its existing final addition check.