Fix management socket path to persist after reboot #1452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use /var/run/openvpn-server/ instead of /var/run/openvpn/ for the management socket. The former is created at boot by OpenVPN's tmpfiles.d configuration, while the latter was manually created and lost on reboot. Fixes #1451
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the OpenVPN management socket path to use a directory that persists across reboots. The change addresses issue #1451 where the management socket directory was lost after system reboot.
Changes:
- Updated management socket path from
/var/run/openvpn/to/var/run/openvpn-server/ - Removed manual directory creation code that is no longer needed (the directory is created by OpenVPN's tmpfiles.d configuration)
- Updated all test assertions to verify the new socket path
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openvpn-install.sh | Updated management socket path in server configuration, removed manual directory creation, and updated disconnectClient function |
| test/server-entrypoint.sh | Updated all test assertions to check for the new management socket path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/var/run/openvpn-server/instead of/var/run/openvpn/for the management socketFixes #1451