This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Fix RTL support when using tagging - calculate right input width #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi. Just noticed that there's a "bug" when using the tagging option within an RTL document. The width of the input wasn't calculated like it should. This pull request fixes it.
|
Can you squash your commits and rebase it on current In addition, it probably is worth having tests here for this functionality. |
|
@dani3l what is the progress on this one? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Just noticed that there's a "bug" when using the tagging option within an RTL document.
The width of the input wasn't calculated like it should.
This pull request fixes it.
Also navigating left/right options is now fixed with 2nd commit.