This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Fix taggingLabel initialization for single mode #1572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix taggingLabel initialization for single mode When taggingLabel is not define in ui-select tag and tagging is active with string (not object), the taggingLabel is undefine and we can see "<value> undefined" in the list. With this code, taggingLabel is initialized with '(new)' as it could be when taggingLabel tag is present whithout value.
|
Is it possible to add a test for this? |
|
I think it's not possible as long as we don't have PR 972, because we can't see tagging element in single mode. |
perf : store tagging element store tagging element to have it all the time without comparing items[0] and filter list of items
This reverts commit e537ede.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix taggingLabel initialization for single mode (when it works)
When taggingLabel is not define in ui-select tag and tagging is active with string (not object), the taggingLabel is undefine and we can see " undefined" in the list.
With this code, taggingLabel is initialized with '(new)' as it could be when taggingLabel tag is present whithout value.