Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Respect custom symbol when creating focusser #1834

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HarpoMarx69
Copy link

@HarpoMarx69 HarpoMarx69 commented Oct 26, 2016

Added featuring start-/endSymbol defined in $interpolateProvider

Fix issue #1831

@user378230
Copy link
Contributor

Thanks @HarpoMarx69 but we could do with a unit test to make sure we don't get this popping up as a regression in future.

Wonder if we could tidy up a little like so:

var focusser = angular.element("<input ng-disabled='$select.disabled' class='ui-select-focusser ui-select-offscreen' type='text'  aria-haspopup='true' role='button' />"); 
focusser.attr("id", $interpolate.startSymbol() + " $select.focusserId " + $interpolate.endSymbol());
focusser.attr("aria-label", $interpolate.startSymbol() + " $select.focusserTitle " + $interpolate.endSymbol());

$compile(...)

(Disclaimer: I don't know if that will actually work?! 😄)

@user378230 user378230 changed the title Fixed issue #1831 Respect custom symbol when creating focusser Nov 2, 2016
@Jefiozie
Copy link
Contributor

Hi @HarpoMarx69 , any luck on the test part so we can merge this?

@HarpoMarx69
Copy link
Author

Sorry, unit tests on this are overchallenging me at the moment...

@dant89
Copy link

dant89 commented Feb 12, 2018

Please can you merge this to master? Very frustrating bug...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants