Skip to content

Revert "fix(@schematics/angular): rename SSR port env variable" #27399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Revert "fix(@schematics/angular): rename SSR port env variable" #27399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/src/builders/ssr-dev-server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ function startNodeServer(
): Observable<void> {
const outputPath = serverOutput.outputPath as string;
const path = join(outputPath, 'main.js');
const env = { ...process.env, SSR_PORT: '' + port, PORT: '' + port };
const env = { ...process.env, PORT: '' + port };

const args = ['--enable-source-maps', `"${path}"`];
if (inspectMode) {
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/src/builders/ssr-dev-server/specs/proxy_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('Serve SSR Builder', () => {
return server;
}

app().listen(process.env['SSR_PORT']);
app().listen(process.env['PORT']);

export * from './app/app.module.server';
`,
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/src/builders/ssr-dev-server/specs/ssl_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('Serve SSR Builder', () => {
return server;
}

app().listen(process.env['SSR_PORT']);
app().listen(process.env['PORT']);

export * from './app/app.module.server';
`,
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/src/builders/ssr-dev-server/specs/works_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe('Serve SSR Builder', () => {
return server;
}

app().listen(process.env['SSR_PORT']);
app().listen(process.env['PORT']);

export * from './app/app.module.server';
`,
Expand Down
2 changes: 1 addition & 1 deletion packages/schematics/angular/migrations/update-17/replace-nguniversal-engines.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export function app(): express.Express {
}

function run(): void {
const port = process.env['SSR_PORT'] || 4000;
const port = process.env['PORT'] || 4000;

// Start up the Node server
const server = app();
Expand Down
2 changes: 1 addition & 1 deletion packages/schematics/angular/migrations/update-17/replace-nguniversal-engines_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export function app(): express.Express {
}

function run() {
const port = process.env.SSR_PORT || 4000;
const port = process.env.PORT || 4000;

// Start up the Node server
const server = app();
Expand Down
2 changes: 1 addition & 1 deletion packages/schematics/angular/ssr/files/application-builder/server.ts.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export function app(): express.Express {
}

function run(): void {
const port = process.env['SSR_PORT'] || 4000;
const port = process.env['PORT'] || 4000;

// Start up the Node server
const server = app();
Expand Down
2 changes: 1 addition & 1 deletion packages/schematics/angular/ssr/files/server-builder/server.ts.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function app(): express.Express {
}

function run(): void {
const port = process.env['SSR_PORT'] || 4000;
const port = process.env['PORT'] || 4000;

// Start up the Node server
const server = app();
Expand Down
2 changes: 1 addition & 1 deletion tests/legacy-cli/e2e/assets/18-ssr-project-webpack/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function app(): express.Express {
}

function run(): void {
const port = process.env['SSR_PORT'] || 4000;
const port = process.env['PORT'] || 4000;

// Start up the Node server
const server = app();
Expand Down