Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): handle relative @ng/components #29386

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

alan-agius4
Copy link
Collaborator

This update serves as a preparatory step to address #29248. The change involves modifying the line 'urlPartial' in r3_hmr_compiler.ts to start with ./ instead of /.

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 17, 2025
@alan-agius4 alan-agius4 requested a review from clydin January 17, 2025 14:26
@alan-agius4 alan-agius4 changed the title refactor(@angular/build): handle relative @ng/components fix(@angular/build): handle relative @ng/components Jan 20, 2025
This update serves as a preparatory step to address angular#29248. The change involves modifying the line 'urlPartial'  in [r3_hmr_compiler.ts](https://github.com/angular/angular/blob/4e6017a9f5cda389c5fbf4f2c1519ce1bba23e11/packages/compiler/src/render3/r3_hmr_compiler.ts#L57) to start with `./` instead of `/`.
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 20, 2025
alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Jan 20, 2025
This change is required to resolve angular/angular-cli#29248 and works in conjunction with angular/angular-cli#29386. It ensures that HMR (Hot Module Replacement) functions correctly with `base href`, proxies, and other advanced development setups.
alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Jan 20, 2025
This change is required to resolve angular/angular-cli#29248 and works in conjunction with angular/angular-cli#29386. It ensures that HMR (Hot Module Replacement) functions correctly with `base href`, proxies, and other advanced development setups.
pkozlowski-opensource pushed a commit to angular/angular that referenced this pull request Jan 20, 2025
This change is required to resolve angular/angular-cli#29248 and works in conjunction with angular/angular-cli#29386. It ensures that HMR (Hot Module Replacement) functions correctly with `base href`, proxies, and other advanced development setups.

PR Close #59620
pkozlowski-opensource pushed a commit to angular/angular that referenced this pull request Jan 20, 2025
This change is required to resolve angular/angular-cli#29248 and works in conjunction with angular/angular-cli#29386. It ensures that HMR (Hot Module Replacement) functions correctly with `base href`, proxies, and other advanced development setups.

PR Close #59620
@alan-agius4 alan-agius4 merged commit 2cbb5a3 into angular:main Jan 20, 2025
30 checks passed
@alan-agius4 alan-agius4 deleted the ng-comp-prefix branch January 20, 2025 09:50
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.1.x

PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
This change is required to resolve angular/angular-cli#29248 and works in conjunction with angular/angular-cli#29386. It ensures that HMR (Hot Module Replacement) functions correctly with `base href`, proxies, and other advanced development setups.

PR Close angular#59620
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

application builder not loading css from localhost correctly with ng serve when using remote dev with HMR
2 participants