fix(@angular/build): avoid attempting to watch bundler internal files #30249
+28
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal bundler (`esbuild`) may use virtual files to represent added content to the output files. This includes names such as `<define:???>` and `<runtime>` to reference object define values and runtime code, respectively. It may also use paths that end with `(disabled):<node_builtin_name>` where `<node_builtin_name>` is one of Node.js' builtin modules. All these cases are now handled by the file watching system and will not be attempted to be watched. Previously these virtual files would be considered removed by the file watching system as they do not actually exist on the file system.
alan-agius4
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal bundler (
esbuild) may use virtual files to represent added content to the output files. This includes names such as<define:???>and<runtime>to reference object define values and runtime code, respectively. It may also use paths that end with(disabled):<node_builtin_name>where<node_builtin_name>is one of Node.js' builtin modules. All these cases are now handled by the file watching system and will not be attempted to be watched. Previously these virtual files would be considered removed by the file watching system as they do not actually exist on the file system.Closes #30197