build: update cross-repo angular dependencies (22.0.x)#33173
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates several Bazel module dependencies and project package versions, including Angular packages and build tools. A review comment highlights an inconsistency in the MODULE.bazel.lock file, where partial hash definitions for older versions remain, and suggests running bazel mod tidy to ensure the lock file is correctly synchronized.
| "https://bcr.bazel.build/modules/aspect_rules_js/3.1.1/MODULE.bazel": "b83cf3ee44837345f1c926d70b96453deb5e244de43d08dcd7acad8d381c275a", | ||
| "https://bcr.bazel.build/modules/aspect_rules_js/3.1.1/source.json": "2806c2d7ce5993f68b74df5f3e2de45d4b2a5798afedd459d88e37c75562da97", |
There was a problem hiding this comment.
The update to aspect_rules_js (and similarly for aspect_rules_ts, package_metadata, and platforms) appears inconsistent in the registryFileHashes section. While hashes for version 3.1.1 were added, the MODULE.bazel hash for the old version 3.0.3 was retained (line 26) while its source.json hash was removed. This results in an invalid state for the lock file where a version is partially defined. It is recommended to run bazel mod tidy to ensure the lock file is correctly synchronized and cleaned of unused version hashes.
There was a problem hiding this comment.
Code Review
This pull request updates various project dependencies and Bazel module configurations. Key changes include bumping Angular-related packages to version 22.0.0-next.12, updating ng-packagr to 22.0.0-next.4, and refreshing several Bazel rules and toolchain versions within MODULE.bazel and MODULE.bazel.lock. There were no review comments provided, so I have no feedback to offer.
14860f1 to
1f65d3a
Compare
See associated pull request for more information.
1f65d3a to
e6f0473
Compare
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This PR contains the following updates:
f084e2e→2c36222f91b383→eaa9aaa19914e2→045f984🔡 If you wish to disable git hash updates, add
":disableDigestUpdates"to the extends array in your config.