Skip to content

fix(ng-dev): use an environment variable to determine local builds #3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
Merged

fix(ng-dev): use an environment variable to determine local builds #3229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ng-dev/utils/version-check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export async function ngDevVersionMiddleware() {
export async function verifyNgDevToolIsUpToDate(workspacePath: string): Promise<boolean> {
// The placeholder will be replaced by the `pkg_npm` substitutions.
const localVersion = `0.0.0-{SCM_HEAD_SHA}`;
if (localVersion === ('0.0.0-{{BUILD_SCM_COMMIT_SHA}}' as string)) {
if (!!process.env['LOCAL_NG_DEV_BUILD']) {
Log.debug('Skipping ng-dev version check as this is a locally generated version.');
return true;
}
Expand Down
2 changes: 1 addition & 1 deletion tools/local-dev.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ bazelCommand=${BAZEL:-"pnpm bazel"}

# Execute the built ng-dev command in the current working directory
# and pass-through arguments unmodified.
${ngDevBinFile} ${@}
LOCAL_NG_DEV_BUILD=1 ${ngDevBinFile} ${@}
Loading