This repository was archived by the owner on Oct 12, 2021. It is now read-only.
fix(worker): correctly emit falsy values sent by the ServiceWorker #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is check that completes the observable on falsy values (`takeWhile(v => !!v)`). This was first introduced in [ffea4ac][1], when there was no other mechanism for completing the observable (and possibly all sent values were objects). Then a different mechanism was introduced in [563e7ac][2], with a stricter check (`data === null`). Since there are types of messages that send boolean values (e.g. [`checkForUpdate`][3] or [`activateUpdate`][4]), it is necessary to not complete the observable on `false`. [1]: ffea4ac#diff-a223d9a67ca2c0a46e98a4f481f74944R133 [2]: 563e7ac#diff-a223d9a67ca2c0a46e98a4f481f74944R148 [3]: https://github.com/angular/mobile-toolkit/blob/f9d83026ea75af1f3a2848903e4072bce19cb5e9/service-worker/worker/src/worker/driver.ts#L850 [4]: https://github.com/angular/mobile-toolkit/blob/f9d83026ea75af1f3a2848903e4072bce19cb5e9/service-worker/worker/src/worker/driver.ts#L856
|
@alxhub, I tried adding some tests but couldn't find an easy way. Glad to work on it if you can give me some pointers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is check that completes the observable on falsy values (
takeWhile(v => !!v)). This was first introduced in ffea4acfe, when there was no other mechanism for completing the observable (and possibly all sent values were objects). Then a different mechanism was introduced in 563e7ac44, with a stricter check (data === null).Since there are types of messages that send boolean values (e.g.
checkForUpdateoractivateUpdate), it is necessary to not complete the observable onfalse.