Skip to content
This repository was archived by the owner on Oct 12, 2021. It is now read-only.

feat(AppShell): shellRender and shellNoRender attributes and allow different element stripping strategies #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgechev
Copy link
Member

@mgechev mgechev commented Jul 8, 2016

  • Make the shell-related directives add shellRender and shellNoRender attributes.
  • Encapsulate the "hiding", "showing" element logic into a service which is injected with DI and can its provider can be overridden.
  • Add visitor which finds App Shell related comments in templates and processes them.

@mgechev mgechev force-pushed the app-shell-directives branch 2 times, most recently from 9e2c349 to 34e3399 Compare July 8, 2016 11:55
@mgechev
Copy link
Member Author

mgechev commented Jul 8, 2016

Fixes #71.

@mgechev mgechev force-pushed the app-shell-directives branch 2 times, most recently from cc3259d to d92257b Compare July 10, 2016 13:39
@mgechev
Copy link
Member Author

mgechev commented Jul 11, 2016

Note that in a browser environment, the DOM adapter needs to be explicitly set:

import { BrowserDomAdapter } from '@angular/platform-browser/src/browser/browser_adapter';
BrowserDomAdapter.makeCurrent();

@mgechev mgechev force-pushed the app-shell-directives branch 2 times, most recently from 823e18a to 2c18098 Compare September 14, 2016 19:01
…t different stripping strategies

- [x] Make the shell-related directives add `shellRender` and `shellNoRender` attributes.
- [x] Encapsulate the "hiding", "showing" element logic into a service which is injected with DI and can its provider can be overridden.
- [x] Add visitor which finds App Shell related comments in templates and processes them.
- [x] Remove useless imports.
@mgechev mgechev force-pushed the app-shell-directives branch from 2c18098 to ec90574 Compare September 22, 2016 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants