Skip to content

Fix macOS arch checks. #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeviticusMB wants to merge 1 commit into
base: legacy
Choose a base branch
from
Open

Fix macOS arch checks. #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/binaries/gecko_driver_github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export class GeckoDriverGithub extends GithubApiConfigSource {
if (item.version === inputVersion) {
let assetsArray = json[item.index].assets;
for (let asset of assetsArray) {
if ((asset.name as string).includes(this.oshelper())) {
if ((asset.name as string).includes(this.oshelper() + '.')) {
return {url: asset.browser_download_url, version: inputVersion};
}
}
Expand All @@ -87,7 +87,7 @@ export class GeckoDriverGithub extends GithubApiConfigSource {
private oshelper(): string {
// Get the os type name.
if (this.ostype === 'Darwin') {
return 'macos';
return this.osarch === 'x64' ? 'macos' : 'macos-aarch64';
} else if (this.ostype === 'Windows_NT') {
return this.osarch === 'x64' ? 'win64' : 'win32';
} else {
Expand Down