Application Insights provider is not setting the name property properly in the custom events...#495
Open
dev-kiranbanda wants to merge 2 commits intoangulartics:masterfrom
Open
Application Insights provider is not setting the name property properly in the custom events...#495dev-kiranbanda wants to merge 2 commits intoangulartics:masterfrom
dev-kiranbanda wants to merge 2 commits intoangulartics:masterfrom
Conversation
https://github.com/Microsoft/ApplicationInsights-JS?tab=readme-ov-file#basic-usage trackEvent is expecting an object and the provider is not setting the name properly. appInsights.trackEvent({ name: 'some event', properties: { // accepts any type prop1: 'string', prop2: 123.45, prop3: { nested: 'objects are okay too' } } });
Update appinsights.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
After switching to the new CDN URLs recommended by Application Insights, it was found that the name property in the custom event is getting recorded as Not_available.
The fix is to call the trackEvent method on the underlying provider with the current parameter structure.
What is the current behavior? Link to open issue?
What is the new behavior?