Skip to content

ci: add 'quality' gate job and gate 'build' with needs; enforce ruff/mypy/coverage use before Docker steps#2

Merged
anibalrojosan merged 2 commits intomainfrom
new-ci-quality-gates
Oct 21, 2025
Merged

ci: add 'quality' gate job and gate 'build' with needs; enforce ruff/mypy/coverage use before Docker steps#2
anibalrojosan merged 2 commits intomainfrom
new-ci-quality-gates

Conversation

@anibalrojosan
Copy link
Owner

What changed in this branch:

  1. Split CI into two jobs in .github/workflows/main.yml:
  • quality: installs deps + QA tooling, runs ruff check ., mypy src, and coverage run -m pytest with --fail-under=80.
  • build-and-push: now depends on quality via needs: quality; proceeds to train, verify model artifact, build/push images, run compose, and probe endpoints.
  1. ruff, mypy and coverage were used for quality testing. Errors founded on scr/ and tests/ folders were fixed.

Why:

  • Fail fast on lint/type/test errors to avoid building/pushing broken images.
  • Keep runtime images clean (QA tools not installed inside images).
  • Provide a consistent, reproducible quality bar for all commits/PRs.

Validation:

  • CI “quality” job passed, and subsequent “build-and-push” completed successfully.

@anibalrojosan anibalrojosan merged commit 8372c46 into main Oct 21, 2025
2 checks passed
@harrueds
Copy link

Nice work master, I always learn something watching your job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants