Skip to content

Optimize SMB client performance with larger buffer sizes #1842 #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
onlymash wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize SMB client performance with larger buffer sizes #1842 #1848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion core/media/src/main/java/dev/anilbeesetti/nextplayer/core/media/network/clients/SmbClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ class SmbClient(private val connection: NetworkConnection) : NetworkClient {
.withMultiProtocolNegotiate(true)
.withSigningRequired(false)
.withEncryptData(false)
// Add large buffer sizes (e.g., 8MB)
.withReadBufferSize(8 * 1024 * 1024)
.withWriteBufferSize(8 * 1024 * 1024)
.build()

val smbClient = SMBClient(config)
Expand Down Expand Up @@ -119,7 +122,8 @@ class SmbClient(private val connection: NetworkConnection) : NetworkClient {
val sess = session ?: error("Not connected")
val share = sess.connectShare(shareName) as DiskShare
val file = openReadFile(share, path)
object : InputStream() {

val rawStream = object : InputStream() {
private var position = offset

override fun read(): Int {
Expand All @@ -138,6 +142,9 @@ class SmbClient(private val connection: NetworkConnection) : NetworkClient {
runCatching { share.close() }
}
}

// Wrap the stream in a 2MB buffer to drastically reduce SMB network requests
return@withContext rawStream.buffered(2 * 1024 * 1024)
}

private fun openReadFile(share: DiskShare, path: String) = share.openFile(
Expand Down