Skip to content

Treat bind-pose skinned meshes as static raytrace sources - #162

Merged
anirul merged 1 commit into
masterfrom
codex/fix-bind-pose-skinned-rt-path
Apr 20, 2026
Merged

Treat bind-pose skinned meshes as static raytrace sources#162
anirul merged 1 commit into
masterfrom
codex/fix-bind-pose-skinned-rt-path

Conversation

@anirul

@anirul anirul commented Apr 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • keep skinned meshes with play_animation = false on the static bind-pose raytracing path
  • gate OpenGL/Vulkan skinning and raytrace buffer updates on active animation instead of bone presence alone
  • add regressions covering animated fox vs bind-pose fox behavior

Verification

  • built FrameOpenGLTest
  • built FrameVulkanTest
  • ran FrameOpenGLTest --gtest_filter='OpenGLRayTracingLevelTest.SkinnedMeshPreRenderUpdatesAggregateSceneBuffers:OpenGLRayTracingLevelTest.SkinnedMeshBindPoseDoesNotUpdateAggregateSceneBuffers:SkinnedMeshTest.LoadFoxGlbCreatesSkinnedMeshWithAnimationData'
  • ran FrameVulkanTest --gtest_filter='VulkanSkinnedRayTracingParseTest.FoxAnimationChangesRaytraceTriangles:VulkanSkinnedRayTracingParseTest.FoxBindPoseDisablesDynamicRaytraceCallbacks'
  • rebuilt grpcmmo_client against the updated Frame submodule

@anirul
anirul merged commit 5bf25a1 into master Apr 20, 2026
1 check passed
@anirul
anirul deleted the codex/fix-bind-pose-skinned-rt-path branch April 20, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant