Refactor get_user_dashboard method in the dao/user.py file #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method has as parameters mentor_or_mentee_received_or_sent and mentorship_relation_state_wanted. It's used to avoid repetitive code in get_user_dashboard method in the same file. Returns a list of relevant relations.
EfthymiaKostaki
changed the title
8 tasks
4 tasks
|
@EfthymiaKostaki resolve the merge conflicts |
devkapilbansal
added
the
Status: Changes Requested
|
@EfthymiaKostaki closing this PR due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request alters the get_user_dashboard method in the dao/user.py file. Changes are made in two different ways. Firstly, we import copy class to use copy.deepcopy method for avoiding code repetition between as_mentor mentorship relations and as_mentee mentorship relations dictionary initialization. Secondly, we add a new method get_state used instead of iterating in a similar for loop multiple times.
Co-authoured with: @StergiosSozos
Fixes #418
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Pre-existing tests have the same outcome as they were before the code changed.
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only