change responses of resend_email and adding testcases

app/api/resources/user.py

@@ -319,10 +319,10 @@ def get(cls, token):
 
 
 @users_ns.route("user/resend_email")
-@users_ns.response(HTTPStatus.OK, "%s" % messages.EMAIL_VERIFICATION_MESSAGE)
-@users_ns.response(HTTPStatus.BAD_REQUEST, "Invalid input.")
-@users_ns.response(HTTPStatus.FORBIDDEN, "%s" % messages.USER_ALREADY_CONFIRMED_ACCOUNT)
-@users_ns.response(HTTPStatus.NOT_FOUND, "%s" % messages.USER_DOES_NOT_EXIST)
+@users_ns.response(HTTPStatus.OK, f"{messages.EMAIL_VERIFICATION_MESSAGE}")
+@users_ns.response(HTTPStatus.BAD_REQUEST, f"{messages.EMAIL_INPUT_BY_USER_IS_INVALID}")
+@users_ns.response(HTTPStatus.FORBIDDEN, f"{messages.USER_ALREADY_CONFIRMED_ACCOUNT}")
+@users_ns.response(HTTPStatus.NOT_FOUND, f"{messages.USER_DOES_NOT_EXIST}")
 class UserResendEmailConfirmation(Resource):
     @classmethod
     @users_ns.expect(resend_email_request_body_model)
@@ -343,7 +343,7 @@ def post(cls):
 
         user = DAO.get_user_by_email(data["email"])
         if user is None:
-            return messages.USER_IS_NOT_REGISTERED_IN_THE_SYSTEM, HTTPStatus.NOT_FOUND
+            return messages.USER_DOES_NOT_EXIST, HTTPStatus.NOT_FOUND
 
         if user.is_email_verified:
             return messages.USER_ALREADY_CONFIRMED_ACCOUNT, HTTPStatus.FORBIDDEN

tests/users/test_api_resend_email.py

@@ -0,0 +1,67 @@
+import unittest
+
+from flask import json
+from http import HTTPStatus
+from app import messages
+from app.database.sqlalchemy_extension import db
+from app.database.models.user import UserModel
+from tests.base_test_case import BaseTestCase
+from tests.test_data import user1, user2, test_admin_user
+
+
+class TestResendEmail(BaseTestCase):
+
+    def setUp(self):
+        super(TestResendEmail, self).setUp()
+        self.resend_url = '/user/resend_email'
+        self.first_user = UserModel(
+            name=user1["name"],
+            email=user1["email"],
+            username=user1["username"],
+            password=user1["password"],
+            terms_and_conditions_checked=user1["terms_and_conditions_checked"],
+        )
+        db.session.add(self.first_user)
+        db.session.commit()
+
+    def test_confirm_email(self):
+        """
+        calling resend_email for a new user and validate the responses
+        """
+        resp = self.client.post(self.resend_url, data=json.dumps({'email': user1['email']}),
+                                content_type='application/json')
+        self.assertEqual(HTTPStatus.OK, resp.status_code)
+        self.assertEqual(messages.EMAIL_VERIFICATION_MESSAGE, json.loads(resp.data))
+        user = UserModel.find_by_email(user1['email'])
+        self.assertEqual(False, user.is_email_verified)
+
+    def test_confirmed_user_send_email(self):
+        """
+        calling resend_email for a user whose email is validated
+        """
+        resp = self.client.post(self.resend_url, data=json.dumps({'email': test_admin_user['email']}),
+                                content_type='application/json')
+        self.assertEqual(HTTPStatus.FORBIDDEN, resp.status_code)
+        self.assertEqual(messages.USER_ALREADY_CONFIRMED_ACCOUNT, json.loads(resp.data))
+
+    def test_wrong_user(self):
+        """
+        calling resend_email for an unknown email
+        """
+        resp = self.client.post(self.resend_url, data=json.dumps({'email': user2['email']}),
+                                content_type='application/json')
+        self.assertEqual(HTTPStatus.NOT_FOUND, resp.status_code)
+        self.assertEqual(messages.USER_DOES_NOT_EXIST, json.loads(resp.data))
+
+    def test_invalid_email(self):
+        """
+        calling resend_email with an invalid email id
+        """
+        resp = self.client.post(self.resend_url, data=json.dumps({'email': 'invalid_email'}),
+                                content_type='application/json')
+        self.assertEqual(HTTPStatus.BAD_REQUEST, resp.status_code)
+        self.assertEqual(messages.EMAIL_INPUT_BY_USER_IS_INVALID, json.loads(resp.data))
+
+
+if __name__ == '__main__':
+    unittest.main()