Introduce Video Resolver API#13
Open
CursedSheep wants to merge 3 commits into
Open
Conversation
- The URL resolver executes at the event when Aniyomi selects a video source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new API called
resolveVideoUrl.Problem:
When browsing an episode, it may have multiple sources (links for different resolutions or subtitles). Currently, the existing extensions resolve all the sources for a single episode. This impacts performance because we only need one video source to watch. To improve this, we should resolve only one video link.
Solution:
To solve the problem, I introduced an API that runs at the event when the user selects an episode/video. The API allows us to handle the resolving process within
resolveVideoUrlbefore the video link is passed to the player, ensuring only the selected link is resolved.