Skip to content

Fix: Update all associated cardIds of a note #18012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SttApollo wants to merge 1 commit into from
+4 −1
Closed

Fix: Update all associated cardIds of a note #18012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,7 +1261,10 @@ class NoteEditor :
// changed did? this has to be done first as remFromDyn() involves a direct write to the database
if (currentEditedCard != null && currentEditedCard!!.currentDeckId() != deckId) {
reloadRequired = true
Copy link
Member

@david-allison david-allison Feb 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested:

  • In the Card Browser in Cards mode
  • From the Reviewer, editing a single card

From a brief overview of the code, this code would update all cards from the note, which is not expected.

undoableOp { setDeck(listOf(currentEditedCard!!.id), deckId) }
// Obtain all card IDs for the current note
val allCardIds = editorNote!!.cardIds(getColUnsafe)
Copy link
Member

@BrayanDSO BrayanDSO Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val allCardIds = editorNote!!.cardIds(getColUnsafe)
val allCardIds = withCol { editorNote!!.cardIds(this) }

// Update the deck for every card of that note
undoableOp { setDeck(allCardIds, deckId) }
// refresh the card object to reflect the database changes from above
currentEditedCard!!.load(getColUnsafe)
// also reload the note object
Expand Down