-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: change "Answer" commands setup #20054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ebff259 to
6686efb
Compare
6686efb to
685a0cd
Compare
685a0cd to
ca8dea1
Compare
david-allison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just doing a quick first-pass review:
Is this a UX regression, in that a user now has to select two actions to perform a 'flip and answer X'
If so, is there any way we can special-case these actions with a checkbox/dialog to save the user time and confusion?
AnkiDroid/src/test/java/com/ichi2/anki/utils/ext/ViewerCommand.kt
Outdated
Show resolved
Hide resolved
If it is a UX regression, depends on what the user expects. Based on the familiarity with AnkiDroid, they may expect "flip and answer". Based on the familiarity with Anki Desktop and the command names, they may expect "answer" Besides the preference upgrade, putting 1, 2, 3, 4, etc as default keybindings for the answer buttons may reduce most of the rest of the AnkiDroid familiarity issue. But in general, it is something that people will complain at the beginning and get used to the more correct approach later.
I'm not sure how are you envisioning that. My first impression is to wait for the confusion to pass. |
|
There's no point in having the |
ca8dea1 to
e009f2e
Compare
|
Feedback addressed. Thanks for the push! Screen_recording_20260108_211222.mp4 |
david-allison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent, thank you!!!!
AnkiDroid/src/main/java/com/ichi2/preferences/ReviewerControlPreference.kt
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/preferences/ReviewerControlPreference.kt
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/preferences/ReviewerControlPreference.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/preferences/ReviewerControlPreference.kt
Outdated
Show resolved
Hide resolved
e009f2e to
545a450
Compare
david-allison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers
removed some tests in ReviewerKeyboardInputTest as fixing them isn't worth it given that the old study screen will be eventually removed
instead of the ViewerCommand Enum, which will be eventually removed
instead of the ViewerCommand Enum, which will be eventually removed
which is more correct and matches Anki Desktop to avoid disrupting the users' workflow because of their previous "show answer" functionality, the bindings are correctly copied to "Show answer" if set to the question side
should be squashed with the last commit. Split to ease the reviewing process
unnecessary after `Answer` gestures got restricted to the answer side
545a450 to
5e0aed2
Compare

Purpose / Description
On Anki Desktop, the "Answer" keybinds only work on the answer side, and that can be a source of confusion between the apps.
As we now allow setting gestures/keybinds to an specific card side, restricting the "Answer [again/hard/good/easy]" commands to the answer side makes sense.
to avoid disrupting the users' workflow because of their previous "show answer" functionality, the bindings are correctly copied to "Show answer" if set to the question side
Also, there's a new dialog for setting the previous
Flip and answerbehaviorApproach
In the commits
How Has This Been Tested?
Unit tests + Emulator 31
Before upgrade
After upgrade
Screen_recording_20260108_211222.mp4
Checklist
Please, go through these checks before submitting the PR.