feat(new-card-browser): Advanced Search [Dev only] #20071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-allison
changed the title
david-allison
force-pushed
the
browser-advanced
branch
from
7a11de4 to
6d3e53a
Compare
david-allison
added
the
Needs Author Reply
This adds a wireframe for an advanced search mode in the Card Browser. Basic operations should can be performed using chips, but advanced operations such as `deck:a*` would not be feasible to display. The advanced mode provides discoverability of many operations which would otherwise only be available in the manual Ignored in the test due to use of `FragmentContainerView` Issue 18709
This commit adds a basic implementation of Advanced Searches:
An advanced search is just a string
UI:
* A list of categorized options is added in tabs
* A category would be 'Tags'
* An option has a title, and an example
* example: Title: **Notes with no tags**; example: `tags:none`
* When the option is clicked, the example is appended to the
search text of the CardBrowserFragment
Strings are hardcoded, there will be a lot of nitpicks on functionality
Code reviews and future commits will replace some options with better
functionality, this should be done before ossifying the strings via translations
Issue 18709
It's unexpected to keep old state when closing the search view
david-allison
force-pushed
the
browser-advanced
branch
from
6d3e53a to
ce11051
Compare
david-allison
removed
the
Needs Author Reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
In this PR, I implement a draft of the 'Advanced Search' functionality for the Card Browser.
As this is development-only functionality, I would ideally like this merged without productionizing the draft functionality. That being said, please heavily review the intent and the existing code.
I plan to productionize this by adding dialog boxes to the provided options, enabling (for example): selection of valid fields in a drop-down list or autocompleting text view.
The main aim of this functionality is to expose Anki's search syntax to users, without them needing to read the manual.
Although we can use chips for a significant portion of common functionality, Anki's functionality is advanced:
fr*nt:text- search all fields matching the wildcarddeck:te*t- a deck search. Not easily representable in the 'deck' chipSo we will provide full text search functionality. Providing explanations, and builders for common functionality will improve discoverability of features, and gives us an opportunity to explain AnkiDroid's features
If this screen passes code reviews, it is intended for various 'small' dialogs to be produced. For example: one which will provide the full list of valid fields to select from.
Fixes
Approach
How Has This Been Tested?
screen-20260111-231015.mp4
Learning
https://docs.ankiweb.net/searching.html
Checklist